Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #572 : allow long duration hydro reservoir #598

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

filippopecci
Copy link
Collaborator

  1. Modified constraint cHydroReservoir in hydro_res.jl so that it applies only to interior time steps (those that are not at the start of a subperiod).
  2. Added a constraint that applies the storage constraint linking first and last time step of each subperiod only for short duration hydro reservoirs.
  3. Renamed constraints in hydro_inter_period_linkage.jl so that the naming is consistent with other long duration storage constraints.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5ccb3ca) 0.30% compared to head (9249449) 0.07%.

Files Patch % Lines
src/model/resources/hydro/hydro_res.jl 0.00% 9 Missing ⚠️
...odel/resources/hydro/hydro_inter_period_linkage.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #598      +/-   ##
========================================
- Coverage   0.30%   0.07%   -0.23%     
========================================
  Files        112     112              
  Lines       3931    3937       +6     
========================================
- Hits          12       3       -9     
- Misses      3919    3934      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filippopecci filippopecci linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @filippopecci for this fix.

@lbonaldo lbonaldo merged commit ac7e929 into main Feb 1, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modelling hydro reservoirs with LDS
2 participants